Link image PR valid with summernote v0.8 #226 #1854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * Image popover shows two new buttons: edit link and remove link * Link dialog hides link text if an image was selected * Prevents show link popover when an image has a link TODO: * Only show remove link button when image has link
|
Just to give you a heads up the plugin https://github.com/StudioJunkyard/summernote-image-attributes now handles links for images as well. |
lqez
force-pushed
the
develop
branch
2 times, most recently
from
c3cfdd5
to
d3b48e5
Compare
|
I'm closing this PR. I hope we can handle this feature in the future again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#226 Link image PR valid with summernote v0.8.2
Changes:
TODO: