Better checks before using non-standard require methods. Fixes #1723.

[mathieumg]

What does this PR do?

My stab at fixing #1723.

Where should the reviewer start?

The only modifications are in src/js/base/core/agent.js

How should this be manually tested?

Built the distributable using grunt dist and tested in a Webpack environment. Don't have an immediate access to a Summernote RequireJS build, maybe users like @jumplee can help.

Any background context you want to provide?

To get Webpack to play along, we cannot simply use runtime checks on require like is currently the case. I'm not familiar enough with RequireJS to know if require.specified works at bundle-time or a runtime. The current fix presumes that command is only executed at runtime. (I added a short eval to trick Webpack) It would be great to get feedback from Summernote RequireJS users about this fix, to end the cycle of breaking different bundlers back and forth across releases.

What are the relevant tickets?

• use summernote as requirejs package ,and don't want to use the codemirror as dependency #379
• require.specified not working with require optimizer? #487
• Webpack and CodeMirror #1171
• Warnings when building with webpack #1723

[hackerwins]

This line should be changed with type of require.resolve !== 'undefined' like a 54 line.

[mathieumg]

Good catch!

[hackerwins]

@mathieumg Thanks for contribution. This commit is works with webpack and requirejs too. Could you fix the line has typeof?

[mathieumg]

Done!

[hackerwins]

@mathieumg Thanks. 👍

[Dorphern]

Awesome @mathieumg! Clever fix, didn't see that myself :)

[graingert]

@mathieumg This still isn't quite right.

You want:

https://github.com/webpack/docs/wiki/api-in-modules#requireresolveweak

[graingert]

@mathieumg maybe it would be better to have summernote allow CodeMirror to be injected into it?

$('#summernote').summernote({
  height: 300,                 // set editor height
  minHeight: null,             // set minimum height of editor
  maxHeight: null,             // set maximum height of editor
  focus: true                  // set focus to editable area after initializing summernote
  codemirror: require('CodeMirror');
});

This is especially important when everyone switched to ES2015 modules where imports need to be statically resolved.

[mathieumg]

@graingert I had stumbled upon resolveWeak, but it says it won't bundle the module whereas we want it to be bundled, if it's available. I wouldn't be against providing codemirror as a parameter, which would only attempt to sniff window.CodeMirror if unspecified. This would allow people with any type of custom bundlers to bundle codemirror (if they so desire) "the right way". What does @hackerwins have to say about it?

ES2015 modules where imports need to be statically resolved

I reckon this is not entirely true, there is System.import which SystemJS and Webpack 2 implement. (Probably others too) See http://exploringjs.com/es6/ch_modules.html#_loader-method-importing-modules