New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The drop-Event in Firefox contains two moz-specific Datatransfer-Type… #3327
Merged
lqez
merged 1 commit into
summernote:develop
from
stefl0n:firefox-text-drop-issue-bugfix
Dec 18, 2019
Merged
The drop-Event in Firefox contains two moz-specific Datatransfer-Type… #3327
lqez
merged 1 commit into
summernote:develop
from
stefl0n:firefox-text-drop-issue-bugfix
Dec 18, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s: "text/_moz_htmlcontext" and "text/_moz_htmlinfo". Those aren't meant to be inserted via .pasteHTML(). So you can prevent the editor from inserting its whole editor DOM (stored in text/_moz_htmlcontext...) by skipping those types from being processed. Ticket-Nr: 2701
lqez
force-pushed
the
develop
branch
2 times, most recently
from
December 14, 2019 07:21
c3cfdd5
to
d3b48e5
Compare
Thanks for your contribution! |
jvnm-dev
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 30, 2019
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR's code summernote/summernote#3327 (with adaptation for our dinosaurus version) OPW-2158112
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Dec 30, 2019
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR's code summernote/summernote#3327 (with adaptation for our dinosaurus version) OPW-2158112 closes #42470 Signed-off-by: Jason Van Malder <jvm-odoo@users.noreply.github.com>
jvnm-dev
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Dec 31, 2019
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR's code summernote/summernote#3327 (with adaptation for our dinosaurus version) OPW-2158112 X-original-commit: bc5ecc2
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Jan 3, 2020
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR's code summernote/summernote#3327 (with adaptation for our dinosaurus version) OPW-2158112 closes #42500 X-original-commit: bc5ecc2 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
jvnm-dev
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 6, 2020
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR's code summernote/summernote#3327 (with adaptation for our dinosaurus version) OPW-2158112
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Jan 6, 2020
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR's code summernote/summernote#3327 (with adaptation for our dinosaurus version) OPW-2158112 closes #42719 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 6, 2020
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR's code summernote/summernote#3327 (with adaptation for our dinosaurus version) OPW-2158112 X-original-commit: 197145a
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Jan 6, 2020
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR's code summernote/summernote#3327 (with adaptation for our dinosaurus version) OPW-2158112 closes #42759 X-original-commit: 197145a Signed-off-by: Jason Van Malder <jvm-odoo@users.noreply.github.com>
jvnm-dev
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 10, 2020
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR's code summernote/summernote#3327 (with adaptation for our dinosaurus version) OPW-2158112 X-original-commit: 197145a
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 10, 2020
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR's code summernote/summernote#3327 (with adaptation for our dinosaurus version) OPW-2158112 X-original-commit: e476456
robodoo
pushed a commit
to odoo/odoo
that referenced
this pull request
Jan 10, 2020
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR's code summernote/summernote#3327 (with adaptation for our dinosaurus version) OPW-2158112 closes #42755 X-original-commit: 197145a Signed-off-by: Jason Van Malder <jvm-odoo@users.noreply.github.com>
fw-bot
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Jan 10, 2020
Issue - Have firefox - Go to any chatter - Open full editor - Write some "test" words with line breaks - Select one of your "test" words - Drag & drop it somewhere else in the editor Welcome on test.com! (redirected) Cause Summernote doesn't preventDefault on drop event, so firefox think we want to go to another URL. Solution Add the preventDefault manually. This reveals another issue which is solved by importing this PR's code summernote/summernote#3327 (with adaptation for our dinosaurus version) OPW-2158112 X-original-commit: 27a0ed8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugfix for issue #2701:
The drop-Event in Firefox contains two moz-specific Datatransfer-Types: "text/_moz_htmlcontext" and "text/_moz_htmlinfo". Those aren't meant to be inserted via .pasteHTML().
So you can prevent the editor from inserting its whole editor DOM (stored in text/_moz_htmlcontext...) by skipping those types from being processed.