Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The drop-Event in Firefox contains two moz-specific Datatransfer-Type… #3327

Merged
merged 1 commit into from Dec 18, 2019

Conversation

stefl0n
Copy link

@stefl0n stefl0n commented Jul 31, 2019

Bugfix for issue #2701:

The drop-Event in Firefox contains two moz-specific Datatransfer-Types: "text/_moz_htmlcontext" and "text/_moz_htmlinfo". Those aren't meant to be inserted via .pasteHTML().

So you can prevent the editor from inserting its whole editor DOM (stored in text/_moz_htmlcontext...) by skipping those types from being processed.

…s: "text/_moz_htmlcontext" and "text/_moz_htmlinfo". Those aren't meant to be inserted via .pasteHTML().

So you can prevent the editor from inserting its whole editor DOM (stored in text/_moz_htmlcontext...) by skipping those types from being processed.
Ticket-Nr: 2701
@lqez lqez self-assigned this Aug 15, 2019
@lqez lqez force-pushed the develop branch 2 times, most recently from c3cfdd5 to d3b48e5 Compare December 14, 2019 07:21
@lqez lqez merged commit 17f9820 into summernote:develop Dec 18, 2019
@lqez
Copy link
Member

lqez commented Dec 18, 2019

Thanks for your contribution!

jvnm-dev pushed a commit to odoo-dev/odoo that referenced this pull request Dec 30, 2019
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112
robodoo pushed a commit to odoo/odoo that referenced this pull request Dec 30, 2019
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112

closes #42470

Signed-off-by: Jason Van Malder <jvm-odoo@users.noreply.github.com>
jvnm-dev pushed a commit to odoo-dev/odoo that referenced this pull request Dec 31, 2019
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112

X-original-commit: bc5ecc2
robodoo pushed a commit to odoo/odoo that referenced this pull request Jan 3, 2020
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112

closes #42500

X-original-commit: bc5ecc2
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
jvnm-dev pushed a commit to odoo-dev/odoo that referenced this pull request Jan 6, 2020
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112
robodoo pushed a commit to odoo/odoo that referenced this pull request Jan 6, 2020
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112

closes #42719

Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Jan 6, 2020
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112

X-original-commit: 197145a
robodoo pushed a commit to odoo/odoo that referenced this pull request Jan 6, 2020
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112

closes #42759

X-original-commit: 197145a
Signed-off-by: Jason Van Malder <jvm-odoo@users.noreply.github.com>
jvnm-dev pushed a commit to odoo-dev/odoo that referenced this pull request Jan 10, 2020
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112

X-original-commit: 197145a
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Jan 10, 2020
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112

X-original-commit: e476456
robodoo pushed a commit to odoo/odoo that referenced this pull request Jan 10, 2020
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112

closes #42755

X-original-commit: 197145a
Signed-off-by: Jason Van Malder <jvm-odoo@users.noreply.github.com>
fw-bot pushed a commit to odoo-dev/odoo that referenced this pull request Jan 10, 2020
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112

X-original-commit: 27a0ed8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants