Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FW][FIX] web_editor: fix summernote text drop on firefox #42500

Closed
wants to merge 1 commit into from
Closed

[FW][FIX] web_editor: fix summernote text drop on firefox #42500

wants to merge 1 commit into from

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Dec 30, 2019

Issue

- Have firefox
- Go to any chatter
- Open full editor
- Write some "test" words with line breaks
- Select one of your "test" words
- Drag & drop it somewhere else in the editor

Welcome on test.com! (redirected)

Cause

Summernote doesn't preventDefault on drop event, so firefox
think we want to go to another URL.

Solution

Add the preventDefault manually.

This reveals another issue which is solved by importing
this PR's code https://github.com/summernote/summernote/pull/3327
(with adaptation for our dinosaurus version)

OPW-2158112

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #42470

@fw-bot
Copy link
Contributor Author

fw-bot commented Dec 30, 2019

Ping @jvm-odoo
Cherrypicking a4eae93 of source #42470 failed

stderr:

error: could not apply a4eae93076b... [FIX] web_editor: fix summernote text drop on firefox
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

@robodoo robodoo added conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot labels Dec 30, 2019
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Dec 30, 2019
@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Dec 30, 2019
[FIX] web_editor: fix summernote text drop on firefox
b72402c 
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112

X-original-commit: bc5ecc2
@jvnm-dev jvnm-dev force-pushed the saas-12.3-12.0-opw-2158112-fix-summernote-firefox-text-drop-jvm-aLBL-fw branch from e8281a9 to b72402c Compare December 31, 2019 08:07
@robodoo robodoo removed the CI 🤖 Robodoo has seen passing statuses label Dec 31, 2019
@jvnm-dev
Copy link

@nle-odoo Conflict solved!

@robodoo robodoo added the CI 🤖 Robodoo has seen passing statuses label Dec 31, 2019
nle-odoo
nle-odoo approved these changes Dec 31, 2019
View reviewed changes
Copy link
Contributor

@nle-odoo nle-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fw-bot r+

@nle-odoo
Copy link
Contributor

nle-odoo commented Jan 3, 2020

robodoo r+

@robodoo robodoo added the r+ 👌 label Jan 3, 2020
robodoo pushed a commit that referenced this pull request Jan 3, 2020
[FIX] web_editor: fix summernote text drop on firefox
db71d0b 
Issue

    - Have firefox
    - Go to any chatter
    - Open full editor
    - Write some "test" words with line breaks
    - Select one of your "test" words
    - Drag & drop it somewhere else in the editor

    Welcome on test.com! (redirected)

Cause

    Summernote doesn't preventDefault on drop event, so firefox
    think we want to go to another URL.

Solution

    Add the preventDefault manually.

    This reveals another issue which is solved by importing
    this PR's code summernote/summernote#3327
    (with adaptation for our dinosaurus version)

OPW-2158112

closes #42500

X-original-commit: bc5ecc2
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
@robodoo robodoo closed this Jan 3, 2020
@robodoo robodoo temporarily deployed to merge January 3, 2020 17:10 Inactive
@fw-bot fw-bot mentioned this pull request Jan 3, 2020
Closed
@nle-odoo nle-odoo deleted the saas-12.3-12.0-opw-2158112-fix-summernote-firefox-text-drop-jvm-aLBL-fw branch January 6, 2020 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nle-odoo nle-odoo nle-odoo approved these changes

Assignees
No one assigned
Labels
CI 🤖 Robodoo has seen passing statuses conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fw-bot @jvnm-dev @nle-odoo @C3POdoo @robodoo