Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated styleWithSpan with styleWithCSS #3602

Merged
merged 2 commits into from
Feb 19, 2020
Merged

Conversation

lqez
Copy link
Member

@lqez lqez commented Feb 18, 2020

What does this PR do?

  • Once upon a time (lol), we'd had an option styleWithSpan which affects on styleWithCss of execCommand. I don't know when and why we removed this option.
  • styleWithSpan could be confused with styleWithCSS so I renamed it as same as its property name of content editable.

How should this be manually tested?

  • Set styleWithCSS as true or false. And apply a format to text.

What are the relevant tickets?

Checklist

  • added relevant tests
  • didn't break anything

@lqez lqez requested a review from easylogic February 18, 2020 11:28
@lqez lqez merged commit 0b704c1 into develop Feb 19, 2020
@lqez
Copy link
Member Author

lqez commented Feb 19, 2020

Thank you so much @easylogic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants