Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new layout blog module #104

Merged
merged 2 commits into from Jan 13, 2017
Merged

Add new layout blog module #104

merged 2 commits into from Jan 13, 2017

Conversation

Katrienvh
Copy link

Type

  • Enhancement

Pull request description

Update the markup of the blog module templates

<nav>
<ul class="pager" role="navigation">

<nav aria-label="...">

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lijkt mij wat vreemd

{% if item.allow_comments %}
<section id="{{ act.Comments }}" class="comments">
<header>
<h3>{{ 'lbl.Comments'|trans|capitalize }}</h3>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

Copy link

@mathiashelin mathiashelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Algemeen: zou je Category.html.twig & Index.html.twig niet gelijk trekken?

<section id="blogArchive" class="blog">
<header role="banner">
<section id="blogArchive" class="blog blog-archive">
<header class="module-header">
<h3>
{% if archive.month %}
{{ 'msg.ArticlesFor'|trans|capitalize|format(archive.start_date|spoondate('F Y',LANGUAGE) ) }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

<thead class="hide">
<div class="module-body">
<table class="table table-hover" itemscope itemtype="http://schema.org/Blog">
<thead class="sr-only">
<tr>
<th class="date">{{ 'lbl.Date'|trans|capitalize }}</th>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

<thead class="hide">
<div class="module-body">
<table class="table table-hover" itemscope itemtype="http://schema.org/Blog">
<thead class="sr-only">
<tr>
<th class="date">{{ 'lbl.Date'|trans|capitalize }}</th>
<th class="title">{{ 'lbl.Title'|trans|capitalize }}</th>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

<h2 itemprop="name"><a href="{{ item.full_url }}" title="{{ item.title }}">{{ item.title }}</a></h2>

<div class="article-info">
<span class="sr-only">{{ 'msg.WrittenBy'|trans|capitalize|format('') }}</span> {{ item.user_id|usersetting('nickname' ) }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

<div class="col-md-2 commentCount">
<header class="module-header">
<h1 itemprop="name">{{ item.title }}</h1>
<span class="sr-only">{{ 'msg.WrittenBy'|trans|capitalize|format('') }} </span>{{ item.user_id|usersetting('nickname' ) }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

<span class="sr-only">{{ 'lbl.InThe'|trans }} </span>{{ 'lbl.Category'|trans }}:
<a itemprop="articleSection" href="{{ item.category_full_url }}">{{ item.category_title }}</a>
{% if item.tags %}
<span class="sr-only">{{ 'lbl.WithThe'|trans }}</span> {{ 'lbl.Tags'|trans|capitalize }}:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

<div class="col-xs-12">
<div class="share-buttons">
<span class="share-button">
{{ 'lbl.Share'|trans|capitalize }}:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

{% if navigation.previous %}
<li class="previous">
<a href="{{ navigation.previous.url }}" rel="prev" title="{{ navigation.previous.title }}">&larr;
<span class="hideText">{{ 'lbl.PreviousArticle'|trans|capitalize }}: </span><span class="title">{{ navigation.previous.title }}</span></a>
<span class="sr-only">{{ 'lbl.PreviousArticle'|trans|capitalize }}: </span><span class="title">{{ navigation.previous.title }}</span></a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

</li>
{% endif %}
{% if navigation.next %}
<li class="next">
<a href="{{ navigation.next.url }}" rel="next" title="{{ navigation.next.title }}"><span class="hideText">{{ 'lbl.NextArticle'|trans|capitalize }}: </span><span class="title">{{ navigation.next.title }}</span> &rarr;</a>
<a href="{{ navigation.next.url }}" rel="next" title="{{ navigation.next.title }}"><span class="sr-only">{{ 'lbl.NextArticle'|trans|capitalize }}: </span><span class="title">{{ navigation.next.title }}</span> &rarr;</a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

<section id="{{ act.Comment }}" class="commentForm">
<header role="banner">
<section id="{{ act.Comment }}" class="comment-form">
<header>
<h3>{{ 'msg.Comment'|trans|capitalize }}</h3>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

<section id="blogArchiveWidget" class="well blog">
<header role="banner">
<section id="blogArchiveWidget" class="blog blog-widget">
<header class="widget-header">
<h3>{{ 'lbl.Archive'|trans|capitalize }}</h3>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

<section id="blogCategoriesWidget" class="well blog">
<header role="banner">
<section id="blogCategoriesWidget" class="blog blog-widget">
<header class="widget-header">
<h3>{{ 'lbl.Categories'|trans|capitalize }}</h3>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

<section id="blogRecentArticlesListWidget" class="well blog">
<header role="banner">
<section id="blogRecentArticlesListWidget" class="blog blog-widget">
<header class="widget-header">
<h3>{{ 'lbl.RecentArticles'|trans|capitalize }}</h3>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

</ul>
</div>
<footer class="widget-footer">
<div class="btn-group">
<a class="btn btn-default" href="{{ geturlforblock('Blog') }}">{{ 'lbl.BlogArchive'|trans|capitalize }}</a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

<a class="btn btn-default" href="{{ geturlforblock('Blog') }}">{{ 'lbl.BlogArchive'|trans|capitalize }}</a>
<a class="btn btn-default" href="{{ widgetBlogRecentArticlesFullRssLink }}">{{ 'lbl.RSSFeed'|trans|capitalize }}</a>
</p>
<a class="btn btn-default" href="{{ widgetBlogRecentArticlesFullRssLink }}">{{ 'lbl.SubscribeToTheRSSFeed'|trans|capitalize }}</a>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

<section id="blogRecentCommentsWidget" class="well blog">
<header role="banner">
<section id="blogRecentCommentsWidget" class="blog blog-widget">
<header class="widget-header">
<h3>{{ 'lbl.RecentComments'|trans|capitalize }}</h3>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ucfirst

@mathiashelin mathiashelin merged commit b05a4a2 into master Jan 13, 2017
@carakas carakas deleted the 135-new-layout-blog-module branch January 25, 2017 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants