Don't replace arithmetic expressions

sumup-oss · Jun 18, 2023 · 55e6bbf · 55e6bbf
1 parent 16abf28
commit 55e6bbf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/packages/eslint-plugin-circuit-ui/prefer-custom-properties/index.spec.ts b/packages/eslint-plugin-circuit-ui/prefer-custom-properties/index.spec.ts
@@ -121,6 +121,15 @@ ruleTester.run('prefer-custom-properties', preferCustomProperties, {
       `,
       errors: [{ messageId: 'refactor' }],
     },
+    {
+      name: 'tagged template expression that does arithmetic with the `theme` property',
+      code: `
+        const styles = (theme) => css\`
+          z-index: \${theme.zIndex.absolute + 1};
+        \`;
+      `,
+      errors: [{ messageId: 'refactor' }],
+    },
     {
       name: 'tagged template expression with conditional `theme` properties',
       code: `

diff --git a/packages/eslint-plugin-circuit-ui/prefer-custom-properties/index.ts b/packages/eslint-plugin-circuit-ui/prefer-custom-properties/index.ts
@@ -149,7 +149,7 @@ export const preferCustomProperties = createRule({
       }
 
       // Computed expressions cannot be auto-fixed.
-      if (computed) {
+      if (computed || node.parent?.type === 'BinaryExpression') {
         context.report({
           node,
           messageId: 'refactor',