Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file extension to react-dates import #2079

Merged
merged 4 commits into from May 2, 2023
Merged

Conversation

connor-baer
Copy link
Member

Purpose

Some fixes that I found while testing the latest next prerelease.

Approach and changes

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label May 2, 2023
@connor-baer connor-baer requested a review from a team as a code owner May 2, 2023 11:07
@changeset-bot
Copy link

changeset-bot bot commented May 2, 2023

🦋 Changeset detected

Latest commit: 16e11ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview May 2, 2023 11:07am

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Merging #2079 (16e11ff) into next (f1b72a4) will decrease coverage by 0.01%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #2079      +/-   ##
==========================================
- Coverage   96.92%   96.91%   -0.01%     
==========================================
  Files         258      258              
  Lines       23166    23163       -3     
  Branches     2165     2165              
==========================================
- Hits        22453    22449       -4     
  Misses        707      707              
- Partials        6        7       +1     
Impacted Files Coverage Δ
...t-ui/components/Calendar/RangePickerController.tsx 51.42% <0.00%> (ø)
...ges/circuit-ui/components/Calendar/RangePicker.tsx 88.23% <100.00%> (ø)
...circuit-ui/components/Calendar/SingleDayPicker.tsx 100.00% <100.00%> (ø)
.../circuit-ui/components/CalendarTag/CalendarTag.tsx 54.41% <100.00%> (-5.45%) ⬇️
...mponents/CalendarTagTwoStep/CalendarTagTwoStep.tsx 53.64% <100.00%> (+2.61%) ⬆️

@connor-baer connor-baer merged commit 36351df into next May 2, 2023
12 of 14 checks passed
@connor-baer connor-baer deleted the bugfix/react-dates-esm branch May 2, 2023 12:02
@connor-baer connor-baer mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants