Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types resolution #2084

Merged
merged 1 commit into from May 8, 2023
Merged

Fix types resolution #2084

merged 1 commit into from May 8, 2023

Conversation

connor-baer
Copy link
Member

Purpose

The package entry points are defined using the exports field since #2061. TypeScript is supposed to be able to resolve the types relative to the path(s) defined in the exports field, but testing the latest next release proves otherwise.

Approach and changes

  • Add back the types field in the package.json files

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label May 6, 2023
@connor-baer connor-baer requested a review from a team as a code owner May 6, 2023 21:19
@connor-baer connor-baer requested review from pdrmdrs and removed request for a team May 6, 2023 21:19
@changeset-bot
Copy link

changeset-bot bot commented May 6, 2023

🦋 Changeset detected

Latest commit: 4faa800

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sumup/design-tokens Patch
@sumup/circuit-ui Patch
@sumup/icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview May 6, 2023 9:20pm

@connor-baer connor-baer added the 🚢 ready to merge Automatically merge the PR once all requirements are met label May 6, 2023
@connor-baer connor-baer changed the title Fix type resolution Fix types resolution May 6, 2023
@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #2084 (4faa800) into next (ba33611) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #2084   +/-   ##
=======================================
  Coverage   96.91%   96.91%           
=======================================
  Files         258      258           
  Lines       23163    23163           
  Branches     2165     2165           
=======================================
  Hits        22449    22449           
  Misses        707      707           
  Partials        7        7           

@connor-baer connor-baer force-pushed the next branch 2 times, most recently from 5e3d899 to 321fee2 Compare May 8, 2023 10:46
@kodiakhq kodiakhq bot merged commit 9677a30 into next May 8, 2023
12 of 13 checks passed
@kodiakhq kodiakhq bot deleted the bugfix/export-types branch May 8, 2023 15:03
@connor-baer connor-baer added this to the v7.0 milestone May 17, 2023
@connor-baer connor-baer mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui 🗂 design-tokens 🗂 icons 🚢 ready to merge Automatically merge the PR once all requirements are met
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants