Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to font-display: optional #2114

Merged
merged 1 commit into from May 21, 2023
Merged

Switch to font-display: optional #2114

merged 1 commit into from May 21, 2023

Conversation

connor-baer
Copy link
Member

Closes #1001.

Purpose

Reduce the layout shift to improve the user experience on page load.

Approach and changes

  • Switch from font-display: swap to font-display: optional for the default Aktiv Grotesk font

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from a team as a code owner May 17, 2023 12:38
@connor-baer connor-baer requested review from tareqlol and removed request for a team May 17, 2023 12:38
@changeset-bot
Copy link

changeset-bot bot commented May 17, 2023

🦋 Changeset detected

Latest commit: 1f720b7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented May 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview May 17, 2023 0:38am

@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #2114 (1f720b7) into next (da1a11b) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #2114   +/-   ##
=======================================
  Coverage   96.88%   96.88%           
=======================================
  Files         258      258           
  Lines       23186    23186           
  Branches     2160     2160           
=======================================
  Hits        22463    22463           
  Misses        715      715           
  Partials        8        8           
Impacted Files Coverage Δ
...cuit-ui/components/BaseStyles/BaseStylesService.ts 100.00% <100.00%> (ø)

@connor-baer connor-baer merged commit f53e433 into next May 21, 2023
14 of 15 checks passed
@connor-baer connor-baer deleted the feature/font-display branch May 21, 2023 07:07
This was referenced Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants