Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tree-shaking of Circuit UI #2185

Merged
merged 3 commits into from Jul 15, 2023
Merged

Fix tree-shaking of Circuit UI #2185

merged 3 commits into from Jul 15, 2023

Conversation

connor-baer
Copy link
Member

Purpose

While upgrading the Next.js template to Circuit UI v7, I discovered that Circuit UI can no longer be tree-shaken because Vite combines all code into a single file. I had assumed that bundlers were smart enough to tree-shake the code regardless.

Approach and changes

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Jul 15, 2023
@connor-baer connor-baer requested a review from a team as a code owner July 15, 2023 19:46
@connor-baer connor-baer requested review from pdrmdrs and removed request for a team July 15, 2023 19:46
@changeset-bot
Copy link

changeset-bot bot commented Jul 15, 2023

🦋 Changeset detected

Latest commit: be7517f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2023 7:58pm

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Merging #2185 (be7517f) into next (4b7dd4d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #2185   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         259      259           
  Lines       20523    20523           
  Branches     1928     1928           
=======================================
  Hits        19818    19818           
  Misses        702      702           
  Partials        3        3           

@connor-baer connor-baer merged commit cf5e82f into next Jul 15, 2023
12 checks passed
@connor-baer connor-baer deleted the fix/unbundle branch July 15, 2023 20:07
@connor-baer connor-baer mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant