Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid input styles #2199

Merged
merged 1 commit into from Jul 23, 2023
Merged

Fix invalid input styles #2199

merged 1 commit into from Jul 23, 2023

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jul 22, 2023

Purpose

Invalid styles are applied when the Input or Select has the aria-invalid attribute, even when the value is false.

Approach and changes

  • Narrow the invalid style selector to target aria-invalid="true" only

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2023

🦋 Changeset detected

Latest commit: 5c5a9ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jul 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2023 9:28am

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

Merging #2199 (5c5a9ac) into next (08fa046) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #2199   +/-   ##
=======================================
  Coverage   96.52%   96.52%           
=======================================
  Files         259      259           
  Lines       20556    20556           
  Branches     1931     1931           
=======================================
  Hits        19842    19842           
  Misses        711      711           
  Partials        3        3           

@connor-baer connor-baer added the 🐞 bug Something isn't working as it should label Jul 23, 2023
@connor-baer connor-baer marked this pull request as ready for review July 23, 2023 07:16
@connor-baer connor-baer requested a review from a team as a code owner July 23, 2023 07:16
@connor-baer connor-baer requested review from tareqlol and removed request for a team July 23, 2023 07:16
@connor-baer connor-baer merged commit 451dbdc into next Jul 23, 2023
12 checks passed
@connor-baer connor-baer deleted the fix/invalid-fields branch July 23, 2023 07:17
@connor-baer connor-baer mentioned this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working as it should 🗂 circuit-ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant