Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert using the experimental Tooltip component in stable components #2489

Merged
merged 7 commits into from
Apr 8, 2024

Conversation

connor-baer
Copy link
Member

This reverts some commits from #2393.

Purpose

Using the experimental Tooltip component in stable components has turned out to be a mistake. Especially the widely-used IconButton has surfaced many edge cases and clashes with existing custom tooltips.

Approach and changes

  • Revert usage of the experimental Tooltip component in the IconButton, Pagination, and Table components

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@connor-baer connor-baer requested a review from a team as a code owner April 8, 2024 13:19
Copy link

changeset-bot bot commented Apr 8, 2024

🦋 Changeset detected

Latest commit: 0b57691

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 8, 2024 1:32pm

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 94.56522% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 87.68%. Comparing base (de7dfda) to head (0b57691).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2489      +/-   ##
==========================================
- Coverage   87.72%   87.68%   -0.05%     
==========================================
  Files         198      198              
  Lines       21241    21209      -32     
  Branches     1287     1281       -6     
==========================================
- Hits        18634    18597      -37     
- Misses       2555     2560       +5     
  Partials       52       52              
Files Coverage Δ
packages/circuit-ui/components/Button/base.tsx 92.59% <100.00%> (+0.82%) ⬆️
...es/circuit-ui/components/ImageInput/ImageInput.tsx 90.03% <100.00%> (-0.07%) ⬇️
...onents/Pagination/components/PageList/PageList.tsx 100.00% <100.00%> (ø)
...omponents/Table/components/SortArrow/SortArrow.tsx 100.00% <100.00%> (ø)
packages/circuit-ui/components/Tag/Tag.tsx 95.88% <100.00%> (-0.08%) ⬇️
...ckages/circuit-ui/components/Button/IconButton.tsx 95.38% <91.37%> (-3.23%) ⬇️

... and 2 files with indirect coverage changes

@connor-baer connor-baer merged commit c97a10a into main Apr 8, 2024
13 of 14 checks passed
@connor-baer connor-baer deleted the revert/tooltip-usage branch April 8, 2024 13:35
@connor-baer connor-baer mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant