Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notification modal #994

Merged
merged 6 commits into from Nov 2, 2021
Merged

Add notification modal #994

merged 6 commits into from Nov 2, 2021

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jun 22, 2021

Addresses #792.

Purpose

Introduces the new NotificationModal component.
Notification modal component communicates critical information, and needs the user's attention or action to proceed.

Screenshot 2021-10-28 at 15 54 09

  • Use a concise headline to communicate the message.
  • If needed, an optional body copy and image can be included.
  • The positioning of the buttons within a button group follows the guidelines of the button group component.

Approach and changes

Refer to the Storybook for further implementation and usage guidelines, and to the threads below for more details and discussion on the implementation.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@vercel
Copy link

vercel bot commented Jun 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/sumup/oss-circuit-ui/5qWPLKCHZwZzUD5cJxEim6j9crSG
✅ Preview: https://oss-circuit-ui-git-feature-ds-169notification-modal-sumup.vercel.app

@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2021

🦋 Changeset detected

Latest commit: 15bcff7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup/circuit-ui Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@connor-baer connor-baer changed the base branch from main to next June 22, 2021 12:32
@connor-baer connor-baer changed the title [DS-169] Add notification modal Add notification modal Jun 22, 2021
@connor-baer connor-baer force-pushed the feature/DS-169/notification-modal branch from a318d72 to ab7d85d Compare July 29, 2021 13:57
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #994 (15bcff7) into main (1c12218) will increase coverage by 0.04%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
+ Coverage   91.80%   91.84%   +0.04%     
==========================================
  Files         180      182       +2     
  Lines        3454     3484      +30     
  Branches     1081     1091      +10     
==========================================
+ Hits         3171     3200      +29     
  Misses        266      266              
- Partials       17       18       +1     
Impacted Files Coverage Δ
.../circuit-ui/components/ButtonGroup/ButtonGroup.tsx 96.00% <ø> (ø)
...mponents/NotificationModal/useNotificationModal.ts 0.00% <0.00%> (ø)
...components/NotificationModal/NotificationModal.tsx 96.55% <96.55%> (ø)
...es/circuit-ui/components/Pagination/Pagination.tsx 91.42% <0.00%> (ø)
...mponents/NotificationBanner/NotificationBanner.tsx 83.60% <0.00%> (+1.63%) ⬆️

@amelako amelako requested review from robinmetral and a team October 28, 2021 13:56
@amelako amelako marked this pull request as ready for review October 28, 2021 14:11
Copy link
Member Author

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't approve because I opened the PR, but you can take this comment as approval 👍🏻👏🏻

🔔⬜

Copy link
Contributor

@robinmetral robinmetral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some questions along with my approval because I probably missed some discussions during the implementation of this component, and I'm interested 🙂

@amelako amelako merged commit 0b7b322 into main Nov 2, 2021
@amelako amelako deleted the feature/DS-169/notification-modal branch November 2, 2021 09:02
@github-actions github-actions bot mentioned this pull request Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants