Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go through armor material #679

Closed
wake42 opened this issue Dec 18, 2023 · 0 comments · Fixed by #678
Closed

Go through armor material #679

wake42 opened this issue Dec 18, 2023 · 0 comments · Fixed by #678
Assignees
@wake42
Labels
type: enhancement Improvement to existing feature. Use "feat: " commit message
Milestone
3.4.1 [done]

Comments

@wake42
Copy link
Collaborator

wake42 commented Dec 18, 2023

Just a note - refine later!

current materials:

"Bronze Plate",
"Cuirboilli",
"Disk Plate",
"Heavy Leather",
"Heavy Scale",
"Iron" - Does not make sense!
"Leather",
"Light Scale",
"Linen",
"Quilted",
"Ring Mail",
"Segmented Bronze Plate",
"Studded Leather",
"Turtle Shell",

The material dropdown should only include the material "style", not the material like iron / bronze

materials from W&E

. Cuirboilli
. Leather
. Leather, Heavy
. Leather, Soft
. Leather, Studded
. Linen
. Mail, Ring
. Plate - What is this if not Bronze?
. Plate, Bronze
. Plate, Disk
. Quilted
. Scale, Light
. Scale, Heavy
. Turtleshell

If the actual material needs to be specified it should be added to the "Name Prefix" field - like Iron Hauberk (Plate).

Alternatively change Plate to Plate, Iron so it becomes Hauberk (Plate, iron)

And maybe change wording to Hauberk (Iron Plate)
@wake42 wake42 added this to the 3.4.1 milestone Dec 18, 2023
@wake42 wake42 added the type: enhancement Improvement to existing feature. Use "feat: " commit message label Dec 18, 2023
@wake42 wake42 self-assigned this Dec 18, 2023
@wake42 wake42 closed this as completed in f1f82f7 Dec 18, 2023
@github-actions github-actions bot mentioned this issue Dec 17, 2023
Merged
wake42 added a commit to sun-dragon-cult/fvtt-module-wiki-rqg that referenced this issue Dec 26, 2023
@wake42
fix: rune type is in Capitals in system but lowercase in wiki
40ea6ad 
closes sun-dragon-cult/fvtt-system-rqg#680
fix: update uiContent.json and correct armor material names
implements sun-dragon-cult/fvtt-system-rqg#679
@wake42 wake42 mentioned this issue Dec 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wake42 wake42

Labels
type: enhancement Improvement to existing feature. Use "feat: " commit message
Projects
None yet
Milestone
3.4.1 [done]
Development

Successfully merging a pull request may close this issue.

chore(main): release 3.4.1 sun-dragon-cult/fvtt-system-rqg
1 participant
@wake42