New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user-supplied fragments config #34

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@Holzhaus

Holzhaus commented Nov 16, 2018

This might come in handy if the user has custom docsets installed, that are not tracked by Kapeli's feed.

Add support for user-supplied fragments config
This might come in handy if the user has custom docsets installed, that
are not tracked by Kapeli's feed.
@sunaku

This comment has been minimized.

Owner

sunaku commented Dec 5, 2018

Good idea. 👍 I hadn't considered custom docsets for this feature. 🤔 I'll merge this after some clean up.

Show resolved Hide resolved bin/dasht-query-line Outdated
Show resolved Hide resolved bin/dasht-query-line Outdated
@@ -241,6 +253,14 @@ dasht-docsets "$@" | while read -r docset; do
fragment_by_docset["jQuery"] = "#content"
fragment_by_docset["jQuery_Mobile"] = "#content"
fragment_by_docset["jQuery_UI"] = "#content"
if (fragments_conf != "") {
while (getline < fragments_conf)

This comment has been minimized.

@sunaku

sunaku Dec 5, 2018

Owner

We might avoid reading the fragments file here if it contents are passed in through -v option for awk.

This comment has been minimized.

@Holzhaus

Holzhaus Dec 5, 2018

Unfortunately, my awk skills are really bad, so I have no idea how to archieve that. Sorry :(

@sunaku sunaku added the enhancement label Dec 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment