Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for user-supplied fragments config #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Holzhaus
Copy link

This might come in handy if the user has custom docsets installed, that are not tracked by Kapeli's feed.

This might come in handy if the user has custom docsets installed, that
are not tracked by Kapeli's feed.
@sunaku
Copy link
Owner

sunaku commented Dec 5, 2018

Good idea. 👍 I hadn't considered custom docsets for this feature. 🤔 I'll merge this after some clean up.

bin/dasht-query-line Outdated Show resolved Hide resolved
bin/dasht-query-line Outdated Show resolved Hide resolved
@@ -241,6 +253,14 @@ dasht-docsets "$@" | while read -r docset; do
fragment_by_docset["jQuery"] = "#content"
fragment_by_docset["jQuery_Mobile"] = "#content"
fragment_by_docset["jQuery_UI"] = "#content"

if (fragments_conf != "") {
while (getline < fragments_conf)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might avoid reading the fragments file here if it contents are passed in through -v option for awk.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, my awk skills are really bad, so I have no idea how to archieve that. Sorry :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants