Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A potential implementation for #50.
To accomplish this, I added a flag to
Engine#run_test_files
that states whether it was triggered by the run_all_test_files event. This flag is passed inDriver#run_all_test_files
.It feels somewhat awkward and highly specific, but I can't think of any other way of being able to trigger this event, as the running of test files is abstracted in the Driver class (which makes perfect sense).
So, it's a working solution, but one that you may or may not think could be improved upon.