This repository has been archived by the owner on Jan 11, 2021. It is now read-only.
Fix travis code coverage #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The installation steps for cargo-travis was deleted by mistake. The CI jobs were succeeding because it was using cache, but recently started to fail because the cache is gone. This fixes it.
|
Well done! I actually did not notice it:) Thanks for fixing the issue. |
|
NP. Seems it is still failing for that |
|
I was thinking if it could be related to using |
|
Yeah the error was strange - seems it is trying to compile against x86 but the docker environment was set up for x86_64. |
|
The failure was caused by SimonKagstrom/kcov#262, and the original commit that caused the issue was reverted. Coveralls worked in the latest build. |
|
Thanks. Well done! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The installation steps for cargo-travis were deleted by mistake.
The CI jobs were succeeding because it was using cache, but recently
started to fail because the cache is gone. This fixes it.