Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Update Dockerfile #1030

Merged
merged 3 commits into from
Jul 16, 2022
Merged

[fix] Update Dockerfile #1030

merged 3 commits into from
Jul 16, 2022

Conversation

adriang-90
Copy link
Contributor

Thins I have done:

  • updated images to newer versions, node and golang
  • pre-build dependencies with go.mod and go.sum && go mod download before copying the rest of the files
  • consolidated multiple RUN commands
  • added --no-cache option
    After that I have reached 22.2 MB size of an image from 332 MB

Copy link
Owner

@sundowndev sundowndev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR @adriang-90 🙏🏻

Added few comments, you may rollback changes on versions as it's managed by @dependabot. We want to keep those version bumps independent and granular.

Dockerfile Outdated Show resolved Hide resolved
@sundowndev sundowndev merged commit 4e3d158 into sundowndev:master Jul 16, 2022
sundowndev added a commit that referenced this pull request Jul 17, 2022
This reverts commit 4e3d158, reversing
changes made to ee1c195.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants