Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address unexpected_cfgs warnings #115

Merged
merged 4 commits into from
May 28, 2024
Merged

Conversation

Urgau
Copy link
Contributor

@Urgau Urgau commented May 24, 2024

This PR updates to the latest nightly and address all the unexpected_cfgs warnings, I could find.

Namely it:

  • uses docsrs instead of doc_cfg, since the former is standard
  • removes the target_env = "gnueabi" condition since no target uses it
  • and removes the allow since there are no other warnings

Fixes #114
r? @sunfishcode

@Urgau
Copy link
Contributor Author

Urgau commented May 24, 2024

@sunfishcode Any idea on what might be the cause of those tests failure?

@sunfishcode
Copy link
Owner

sunfishcode commented May 24, 2024

It looks like updating to nightly-2024-05-18 breaks the trick that the compute_static_start function in src/relocate.rs is using to obtain the address of _start before relocation, in -C target-feature=+crt-static mode. I'm not immediately sure how to fix it.

@sunfishcode
Copy link
Owner

I'm experimenting with #116 as a possible fix for this issue.

@sunfishcode
Copy link
Owner

I've now merged #116, which should fix the failures on Rust nightly. Would you mind rebasing on that?

@Urgau
Copy link
Contributor Author

Urgau commented May 28, 2024

Not at all. Rebased.

@sunfishcode
Copy link
Owner

Thanks!

@sunfishcode sunfishcode merged commit f7c8a49 into sunfishcode:main May 28, 2024
5 checks passed
@sunfishcode
Copy link
Owner

This is now released in origin 0.18.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the check-cfg lint config
2 participants