Fix relocation to work on the latest Rust nightly. #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunfishcode
force-pushed
the
sunfishcode/static-start
branch
2 times, most recently
from
d84b2de
to
4ba17ac
Compare
The trick of using a static variable initialized with an address to obtain the pre-relocated address no longer appears to work on Rust nightly, so replace it with code that reads the static start address out of the `e_start` field of the executable's ELF header. This is less "sneaky", so it should be more robust against compiler changes. And, fix the 32-bit x86 relocation code and re-enable all the tests on x86.
sunfishcode
force-pushed
the
sunfishcode/static-start
branch
from
4ba17ac
to
b0876fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The trick of using a static variable initialized with an address to obtain the pre-relocated address no longer appears to work on Rust nightly, so replace it with code that reads the static start address out of the
e_startfield of the executable's ELF header. This is less "sneaky", so it should be more robust against compiler changes.And, fix the 32-bit x86 relocation code and re-enable all the tests on x86.