Popup doesn't close if the history mode is not on

[baykingsea]

Sunil - thanks for building a great example. I had tried some other vue npms and samples nothing worked except yours for MSAL. I hope this question is for real since the last two from me turned out to have answers in the services

The code works fine. But when I move the code to production which doesn't support the history mode i.e. my production url has a # in it, it doesn't close the popup. I can see that authorization has happened and I can see tokens in popup window url has well. I unfortunately cannot turn off the # in the production url because that is how the client wants it. Is there a way to handle this scenario?

[sunilbandla]

Which browser is it happening in? This was a common issue with AngularJS I think. Have you checked stackoverflow?

…

On Wed, May 16, 2018, 11:13 PM baykingsea ***@***.***> wrote: Sunil - thanks for building a great example. I had tried some other vue npms and samples nothing worked except yours for MSAL. I hope this question is for real since the last two from me turned out to have answers in the services The code works fine. But when I move the code to production which doesn't support the history mode i.e. my production url has a # in it, it doesn't close the popup. I can see that authorization has happened and I can see tokens in popup window url has well. I unfortunately cannot turn off the # in the production url because that is how the client wants it. Is there a way to handle this scenario? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAqLnZ-8ZtdgCC9x-0GJUroPPfYTLxgVks5tzRUegaJpZM4UCd39> .

[baykingsea]

Both Chrome and Firefox. I couldn't find anything on the stack overflow else I would not have troubled you. Thanks again for creating this plugin and your help.

[baykingsea]

The homepage url looks like this: www.mydomain.com/website#/ If the has is not there it works fine then.

[sunilbandla]

Have you already created an issue in the msal repo with the repro code?

…

On Thu, May 17, 2018, 8:24 PM baykingsea ***@***.***> wrote: The homepage url looks like this: www.mydomain.com/website#/ — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAqLnd9qK6MKqx_ghURFpdprE6gXfRGMks5tzj7ZgaJpZM4UCd39> .

[baykingsea]

No I haven't. I am using your code, without any changes.

[sunilbandla]

Can you please check with them if such URLs are supported?

…

On Thu, May 17, 2018, 9:53 PM baykingsea ***@***.***> wrote: No I haven't. I am using your code, without any changes. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAqLnRpzf4BR5tNCu0Z3MHJeng68UtYeks5tzlPBgaJpZM4UCd39> .

[bribar]

Hey @baykingsea ,

I came across this issue and figured out why. I don't think it has to do with the hash, but I could be wrong. Mine was doing same thing but I don't have hashes in url.

I was instantiating the msal library in a component that was within a <div v-if="">, so on a button click I would show that v-if div. Problem was...when the redirect occurred in the popup window the component with msal wasn't loaded because it only happens on click, therefore popup doesn't close and more importantly the promise doesn't complete.

Just thought I'd share...

Nice example @sunilbandla

[KenjiDuggan]

Hey! I really appreciate you creating this integration for vue.js, I can't seem to get passed this error even though I've registered the URL in the platform, any idea you know something else that is causing this?

[sunilbandla]

Can you try creating a new application in the portal and add the reply URL? If that doesn't work, asking on stackoverflow will help.