Remove incorrect linux icon config to fix linux app no icon issue #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the official electron-builder doc: > Linux icon set will be generated automatically based on the macOS > `icns` file or common `icon.png`. > > Or you can put them into the `build/icons` directory if you want to > specify them yourself. > The filename must contain the size (e.g. `256x256.png`) of the icon). > Recommended sizes: 16, 32, 48, 64, 128, 256 (or just 512). The old config is somehow wrong. Reference: - https://www.electron.build/icons#linux
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Wow! This is great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the official electron-builder doc:
The old config is somehow wrong.
Visual comparison:
Reference: