Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider removing OpenStruct usage #124

Closed
viralpraxis opened this issue Feb 23, 2024 · 2 comments · Fixed by #127
Closed

Consider removing OpenStruct usage #124

viralpraxis opened this issue Feb 23, 2024 · 2 comments · Fixed by #127

Comments

@viralpraxis
Copy link
Contributor

Ruby MRI 3.3 throws performance-related warnings:

gems/service_actor-3.7.0/lib/service_actor/result.rb:11: warning: OpenStruct use is discouraged for performance reasons

Can we refactor ServiceActor::Result so that it doesn't inherit from OpenStruct?
@viralpraxis
Copy link
Contributor Author

viralpraxis commented Feb 24, 2024 •
edited
Loading

Just found this issue: #53

If there's no active development regarding that issue I'm going to provide a PoC implementation soon

@sunny
Copy link
Owner

sunny commented Feb 24, 2024

Thank you for suggesting this. Yeah removing OpenStruct is something we’d like. Would love to see a PoC! 🎉

@sunny sunny mentioned this issue Feb 26, 2024
Closed
@viralpraxis viralpraxis mentioned this issue Feb 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop ostruct usage viralpraxis/actor
2 participants
@sunny @viralpraxis