Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #124
I decided to try to make
ServiceActor::Result
a wrapper around hash instead of defining methods because 1) playing actors in sequence is basically about merging hashes, 2) it's just easier to implement and reason about, 3) I'd like not to to use metaprogramming if it's not required 4) that's basically how ostruct could be implemented (see ruby/ostruct#51 exceptBasicObject
idea)Seems like resolving #53 will be as easy as tweaking result's
#method_missing/#respond_to_missing
@sunny could you please take a look?