Verify origins do not collide with ServiceActor::Result object methods

[viralpraxis]

Resolves #137

I'm not sure about removing display-related tests and code, but since we do not allow these methods in inputs/outputs seems like we dont have to be specific about display

Also added some tests and removed lonely require ostruct

> irb(main):004:0> RUBY_VERSION
> => "3.0.6"
> irb(main):005:0> ServiceActor::Result.instance_methods.to_s
> => "[:merge!, :key?, :inspect, :failure?, :delete, :[], :[]=, :fail!, :success?, :to_h, :pretty_print_instance_variables, :pretty_print_cycle, :pretty_print, :pretty_print_inspect, :taint, :tainted?, :untaint, :untrust, :untrusted?, :trust, :methods, :singleton_methods, :protected_methods, :private_methods, :public_methods, :instance_variables, :instance_variable_get, :instance_variable_set, :instance_variable_defined?, :remove_instance_variable, :instance_of?, :kind_of?, :is_a?, :gem, :class, :frozen?, :then, :public_send, :method, :public_method, :singleton_method, :tap, :define_singleton_method, :extend, :clone, :yield_self, :pretty_inspect, :to_enum, :enum_for, :<=>, :===, :=~, :!~, :nil?, :eql?, :respond_to?, :freeze, :object_id, :send, :to_s, :display, :hash, :singleton_class, :dup, :itself, :!, :==, :!=, :equal?, :instance_eval, :instance_exec, :__id__, :__send__]"

[viralpraxis]

I tweaked implementation and not the total list of "dangerous" methods is much shorter:

# ServiceActor::Result.instance_methods
:merge!
:send
:__delete__
:key?
:pretty_print
:failure?
:inspect
:fail!
:class
:success?
:[]=
:[]
:kind_of?
:is_a?
:respond_to?
:to_h
:equal?
:!
:__send__
:==
:!=
:__binding__
:instance_eval
:instance_exec
:__id__

But one issue still remains, using these symbols in inputs/outputs/aliases will trigger the warning AND will
produce unexpected result in runtime:

[7] pry(main)> klass = Class.new(Actor) { input :inspect };
DEPRECATED: Defining inputs, outputs or alias_input that collide with `ServiceActor::Result` instance methods will lead to runtime errors in the next major release of Actor. Problematic input: `inspect`
[8] pry(main)> klass.call(inspect: 1).inspect
=> "<ServiceActor::Result {:inspect=>1}>"

In latest release (3.7.0) inspect would have been redefined and ServiceActor::Result#inspect would return 1.

cc @sunny

[sunny]

I tweaked implementation and not the total list of "dangerous" methods is much shorter

That is awesome. 😍 Kudos on using a BasicObject yet adding the basic methods it would need.

But one issue still remains, using these symbols in inputs/outputs/aliases will trigger the warning AND will produce unexpected result in runtime

Oh, you’re right. So perhaps this should simply raise an ArgumentError straight away as the current behavior is already impacter. Now that the list of methods is smaller I don’t think we need a warning here.

[sunny]

Excellent! Not only does this warn of collisions it actually reduces it thanks to the SimpleObject. 👏🏻

[viralpraxis]

@sunny I encountered a specific but crucial bug related to this PR. Gonna try to fix it soon