Autogenerate *? methods for outputs.

[rockwellll]

This is a continuation of #58. Closes #58

Since these methods are not often used and there is no guarantee the developer would want one. They are only generated when a call is made for an output value that has been defined.

This way, these methods(ending with ?) will never be generated if not called.

This uses the standard way OpenStruct defines methods, in listening to method_missing and checking if there is an attribute defined on the object.

    def method_missing(symbol, *args)
      attribute = symbol.to_s.chomp("?")

      if symbol.end_with?("?") && respond_to?(attribute)

Then, we define the method on the fly and call it immediatly to return the result to the caller.

        define_singleton_method symbol do
          attribute_value = send(attribute.to_sym)

          # ActiveSupport ships with native #present?
          # Delegate to ActiveSupport's Object#present? if ActiveSupport is present
          attribute_value.respond_to?(:present?) ? attribute_value.present? : !blank?(attribute_value)
        end

[sunny]

Awesome 😍

Can you also add a line in the README, under the unreleased section? 🙏🏻

[rockwellll]

Awesome 😍

Can you also add a line in the README, under the unreleased section? 🙏🏻

I'm sorry. do you mean the CHANGELOG.md file?

[sunny]

Woops, my bad. Yes, the CHANGELOG 😅

[rockwellll]

@sunny. I've updated the codebase. Let me know if there are any other issues!.

[sunny]

To follow the RSpec/ContextWording RuboCop convention, contexts should start with when, with or without.

Suggested change

	context "String" do
	context "when input is a String" do

[sunny]

There are a few code-style suggestions that deserved to change so I changed the RuboCop configuration a bit to prefer double-quoted strings for example.

Can you fetch the latest version:

• git fetch origin
• git merge origin/main
• bundle install

Make sure RuboCop & RSpec run smoothly:

• bin/rubocop
• bin/rspec

🙏🏻

[rockwellll]

• bin/rubocop

Thanks for these guides. I've only left with two RuboCop offences

Should this be neglected?

[sunny]

Yes, let’s turn this one off. Can you add the following to the .rubocop conf?

Style/DoubleNegation:
  Enabled: false

Also tests seem to fail on Ruby lower than 3. I think that’s because hash is actually Ruby method that return each object’s internal id. So in the spec we should probably use a different name for the result value, like options :)

[rockwellll]

Hopefully. It won't give any more errors 💀

[rockwellll]

@sunny any updates on this PR?.

[sunny]

Looks good! That's a great addition to Actor, thank you \o/ 🎉