Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer "inclusion" argument to "in" 🐹 #84

Merged
merged 1 commit into from
Sep 8, 2022
Merged

Conversation

sunny
Copy link
Owner

@sunny sunny commented Sep 4, 2022

Following #82, the name inclusion is clearer than in for input arguments.

Deprecation-wise, the idea is to:

  • in this patch, soft-deprecate the in argument by allowing both syntaxes and removing the previous syntax from the documentation,
  • later, deprecate the in argument with a warning on use,
  • later, drop the in argument, on a major version upgrade.

@sunny sunny enabled auto-merge (squash) September 8, 2022 22:25
@sunny sunny disabled auto-merge September 8, 2022 22:25
@sunny sunny merged commit f47462b into main Sep 8, 2022
@sunny sunny deleted the prefer-inclusion-to-in branch September 8, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant