Check more things in test helpers #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cadair
previously requested changes
Apr 25, 2024
ndcube/tests/helpers.py
Outdated
| low_level_wcs = wcs1 | ||
| if isinstance(wcs1, BaseHighLevelWCS): | ||
| low_level_wcs = wcs1.low_level_wcs | ||
| np.testing.assert_array_equal(low_level_wcs.pixel_to_world_values(*random_idx.T), low_level_wcs.pixel_to_world_values(*random_idx.T)) |
There was a problem hiding this comment.
Is this line just testing that low_level_wcs is equivalent to itself?
There was a problem hiding this comment.
No, it was meant to test two different low level wcs from the input cubes.
This is a typo.
ndcube/tests/helpers.py
Outdated
| @@ -95,9 +96,11 @@ def assert_metas_equal(test_input, expected_output): | |||
| assert test_input[key] == expected_output[key] | |||
|
|
|||
|
|
|||
| def assert_cubes_equal(test_input, expected_cube): | |||
| def assert_cubes_equal(test_input, expected_cube, check_data=False): | |||
There was a problem hiding this comment.
Why make checking data an option? Why not always do it?
There was a problem hiding this comment.
Depending on the size of the data, this could slow down the unit test, especially if do not care if the data changed (or not).
There was a problem hiding this comment.
Let's make the default of check_data=True then.
Co-authored-by: Stuart Mumford <stuart@cadair.com>
DanRyanIrish
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.