Add a rust linter and formatter (Take 2) #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
reviewed
May 4, 2024
.pre-commit-config.yaml
Outdated
| hooks: | ||
| - id: cargo-check | ||
| - id: clippy | ||
| args: ["--allow-staged", "--fix", "--", "-A", "clippy::needless_return"] |
There was a problem hiding this comment.
You didn't want to config this?
There was a problem hiding this comment.
As far as I can tell there isn't a decent way to config this which works with the slightly old rust I have on my system :p
Merged
nabobalis
reviewed
May 7, 2024
| @@ -0,0 +1,20 @@ | |||
| name: pre-commit | |||
nabobalis
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some rust specific pre-commit hooks as recommended by @Will-Shanks in #110
It seems that these checks don't play nice with pre-commit.ci so I have swapped to using pre-commit.ci lite and GH actions to run them, which means enabling autofix.
Oh, also somewhat controversially I have configured clippy to enforce the presence of return statements, as I think that will be better for people likely to contribute here who are more familiar with Python.