Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build more wheels #138

Merged
merged 4 commits into from
May 7, 2024
Merged

Build more wheels #138

merged 4 commits into from
May 7, 2024

Conversation

Cadair
Copy link
Member

@Cadair Cadair commented May 7, 2024

Builds more wheels, is based off #137

@Cadair Cadair added Run Publish Build wheels on a PR Run Cron CI Run the cron CI jobs on a PR labels May 7, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.85%. Comparing base (ae934de) to head (967ed55).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #138      +/-   ##
==========================================
+ Coverage   96.82%   96.85%   +0.02%     
==========================================
  Files           2        2              
  Lines         126      127       +1     
==========================================
+ Hits          122      123       +1     
  Misses          4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Cadair Cadair removed Run Publish Build wheels on a PR Run Cron CI Run the cron CI jobs on a PR labels May 7, 2024
@Cadair Cadair added Run Publish Build wheels on a PR Run Cron CI Run the cron CI jobs on a PR labels May 7, 2024
@Cadair Cadair marked this pull request as ready for review May 7, 2024 14:49
@Cadair Cadair requested a review from nabobalis May 7, 2024 14:49
@@ -117,9 +123,26 @@ jobs:
test_command: 'pytest -p no:warnings --doctest-rst --pyargs streamtracer'
submodules: false
targets: |
- cp3{10,11,12}-manylinux*_x86_64
- cp3{10,11,12}-manylinux_aarch64
Copy link
Contributor

@nabobalis nabobalis May 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think with this, we cover basically everything (normal)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so. Building for ppc etc is rather pointless unless someone asks for it.

Cargo.toml Show resolved Hide resolved
@Cadair Cadair merged commit b633aac into sunpy:main May 7, 2024
22 of 23 checks passed
@Cadair Cadair deleted the wheels branch May 7, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run Cron CI Run the cron CI jobs on a PR Run Publish Build wheels on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants