Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Occult 2 #31

Merged
merged 58 commits into from
Aug 27, 2019
Merged

Occult 2 #31

merged 58 commits into from
Aug 27, 2019

Conversation

vatch123
Copy link
Contributor

@vatch123 vatch123 commented Jun 3, 2019 •
edited
Loading

Description

The python version of the occult2.

TODO:

  • Review of PR
  • ~100% test line coverage
  • Code formatted/linted.
  • Example and documentation is detailed.

Fixes #9

@pep8speaks
Copy link

pep8speaks commented Jun 3, 2019 •
edited
Loading

Hello @vatch123! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 40:101: E501 line too long (101 > 100 characters)

Comment last updated at 2019-08-23 16:36:13 UTC

@ghost
Copy link

ghost commented Jun 3, 2019 •
edited by ghost
Loading

Thanks for the pull request @vatch123! Everything looks great!

wafels
wafels reviewed Jun 3, 2019
View reviewed changes
sunkit_image/enhance.py Outdated Show resolved Hide resolved
wafels
wafels reviewed Jun 3, 2019
View reviewed changes
sunkit_image/enhance.py Outdated Show resolved Hide resolved
wafels
wafels reviewed Jun 3, 2019
View reviewed changes
sunkit_image/enhance.py Outdated Show resolved Hide resolved
wafels
wafels reviewed Jun 3, 2019
View reviewed changes
sunkit_image/enhance.py Outdated Show resolved Hide resolved
@nabobalis nabobalis added this to the v0.1.0 milestone Jun 6, 2019
wafels
wafels reviewed Jun 6, 2019
View reviewed changes
sunkit_image/enhance.py Outdated Show resolved Hide resolved
nabobalis
nabobalis reviewed Jun 6, 2019
View reviewed changes
changelog/31.feature.rst Outdated Show resolved Hide resolved
@nabobalis
Copy link
Contributor

I think the occult code should be in a new file called trace or something better.

@nabobalis nabobalis force-pushed the occult branch 13 times, most recently from 4135e03 to bd3be60 Compare August 21, 2019 22:28
wafels
wafels reviewed Aug 22, 2019
View reviewed changes
examples/tracing_loops.py Outdated Show resolved Hide resolved
examples/tracing_loops.py Outdated Show resolved Hide resolved
examples/tracing_loops.py Outdated Show resolved Hide resolved
examples/tracing_loops.py Outdated Show resolved Hide resolved
sunkit_image/tests/test_trace.py Show resolved Hide resolved
sunkit_image/trace.py Outdated Show resolved Hide resolved
sunkit_image/trace.py Outdated Show resolved Hide resolved
sunkit_image/trace.py Outdated Show resolved Hide resolved
sunkit_image/trace.py Outdated Show resolved Hide resolved
sunkit_image/utils/utils.py Outdated Show resolved Hide resolved
@nabobalis
Copy link
Contributor

pep8speaks is complaining, any chance you can look into them and fix it?

@wafels
Copy link
Member

wafels commented Aug 23, 2019

Approved.

Cadair
Cadair approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@Cadair Cadair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me after a brief check

@nabobalis nabobalis merged commit 21a7a52 into sunpy:master Aug 27, 2019
@nabobalis
Copy link
Contributor

Thanks everyone for the reviews and @vatch123 for the PR!

@vatch123 vatch123 deleted the occult branch August 27, 2019 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wafels wafels wafels approved these changes

@Cadair Cadair Cadair approved these changes

@nabobalis nabobalis nabobalis approved these changes

Assignees
No one assigned
Labels
Feature Request [Review]
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.

OCCULT-2 algorithm
5 participants
@vatch123 @pep8speaks @nabobalis @wafels @Cadair