Adds basic tests for all main meshes. #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
reviewed
Jun 21, 2021
|
Do we need a changelog for tests? |
|
Sure add a trivial one. |
jeffreypaul15
changed the title
|
I'm just going to close and open this to see if codecov responds. |
|
Ah excellent, +52% coverage isn't bad 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
Tests that increase the codecov of the project, we still need to decide how to test meshes.
As of now, I'm testing each individual mesh with it's
n_cellsandn_pointsvalue.Based on how Combine meshes from plot_field_lines() into a single StructuredGrid? #21 goes, we need to decide whether to access each field line separately as they are added together and there isn't any way to get all the field lines and check their number of cells/points.