-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a MultiBlock to store each plotted mesh. #24
Conversation
You mean by name? Could you add a test for these changes please? |
Yeah as of now once converted to a MultiBlock thery're part of an array, would it be wise to store a
Yeah, at the time none of the tests were written, I'll add them in today. |
I think its fine. |
I'm sorry, I didn't quite get you, fine as in fine to go ahead with it? |
Yeah |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks 👍 - the new all_meshes
attribute should be documented in the docstring of SunpyPlotter
. This can be done by adding an
Attributes
----------
section underneath the parameters section.
Co-authored-by: David Stansby <dstansby@gmail.com>
MultiBlocks work as an array of meshes.
Field lines are added into a separate MultiBlock which is then added to the MultiBlock of the plot.
We need to find a way to refer to each mesh other than it's position in the MultiBlock, but I think that can be done later?