This repository has been archived by the owner on May 17, 2021. It is now read-only.

Explain defaults in code examples #111

Closed

Cadair opened this issue Jun 26, 2014 · 1 comment

Labels

Referee Comments Solar Data Search and Retrieval

Milestone

Referee Response

Member

Cadair commented Jun 26, 2014

There are sometimes details not explained in the examples. For example, line 23 on page 11. Probably some readers can figure out that the library is using this to construct the actual path for the files based on attributes in the object, but it may look a bit mysterious to others. Probably in this case a simple comment saying that this will result in files being moved into different directories according to the instrument and detector.

Cadair added Referee Comments labels

Cadair added this to the Referee Response milestone

ehsteve added a commit to ehsteve/sunpy-0.4-paper that referenced this issue


          fix for issue sunpy#111

5bcf97f

Member

aringlis commented Aug 25, 2014

Dealt with by PR #128

aringlis closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.