This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Changes to address review from editors #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nabobalis
commented
Jan 20, 2023
nabobalis
commented
Jan 20, 2023
nabobalis
commented
Jan 20, 2023
nabobalis
commented
Jan 22, 2023
nabobalis
commented
Jan 22, 2023
nabobalis
commented
Jan 27, 2023
| @@ -20,6 +20,8 @@ | |||
| \newcommand{\astropy}{Astropy\xspace} | |||
| \newcommand{\astropypkg}{\package{astropy}} | |||
| \newcommand{\aiapypkg}{\package{aiapy}} | |||
| \newcommand{\pfsspypkg}{\package{pfsspy}} | |||
| \newcommand{\soarpkg}{\package{sunpy\_soar}} | |||
There was a problem hiding this comment.
Ah I should have escaped it. Doh
|
precommit unhappy: |
dstansby
reviewed
Jan 27, 2023
Co-authored-by: David Stansby <dstansby@gmail.com>
|
We can just ignore the pre commit, enquote and added don't seem to play well together. |
|
Lol yeah sorry I should've stuck that in a comment. I had to move those to the usual LaTeX quote style because of the track changes markup. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.