Merge pull request #7662 from nabobalis/ana_fix

Update ANA for GCC 14

changelog/7662.bugfix.rst

@@ -0,0 +1 @@
+Fix compilation with gcc 14, avoid implicit pointer conversions.

sunpy/io/src/ana/_pyana.c

@@ -260,7 +260,7 @@ static PyObject * pyana_fzwrite(PyObject *self, PyObject *args) {
     int compress = 1, debug=0;
     char *header = NULL;
     // Processed data goes here
-    PyObject *anadata_align;
+    PyArrayObject *anadata_align;
     uint8_t *anadata_bytes;
     // ANA file writing
     int	type, d;
@@ -334,7 +334,7 @@ static PyObject * pyana_fzwrite(PyObject *self, PyObject *args) {
     // Sanitize data, make a new array from the old array and force the
     // NPY_ARRAY_CARRAY_RO requirement which ensures a C-contiguous and aligned
     // array will be made
-    anadata_align = PyArray_FromArray(anadata, PyArray_DESCR(anadata),NPY_ARRAY_CARRAY_RO);
+    anadata_align = (PyArrayObject*) PyArray_FromArray(anadata, PyArray_DESCR(anadata),NPY_ARRAY_CARRAY_RO);
 
     // Get a pointer to the aligned data
     anadata_bytes = (uint8_t*) PyArray_DATA(anadata_align);
@@ -344,12 +344,10 @@ static PyObject * pyana_fzwrite(PyObject *self, PyObject *args) {
     int *dims = malloc(nd*sizeof(int));
     // Get the dimensions and number of elements
     npy_intp *npy_dims = PyArray_DIMS(anadata_align);
-    //npy_intp npy_nelem = PyArray_SIZE(anadata_align);
 
     if (debug == 1) printf("pyana_fzwrite(): Dimensions: ");
     for (d=0; d<nd; d++) {
         // ANA stores dimensions the other way around?
-        //dims[d] = npy_dims[d];
         dims[d] = npy_dims[nd-1-d];
         if (debug == 1) printf(" %d", dims[d]);
     }
@@ -363,6 +361,5 @@ static PyObject * pyana_fzwrite(PyObject *self, PyObject *args) {
         ana_fzwrite(anadata_bytes, filename, dims, nd, header, type);
 
     free(dims);
-    // If we didn't crash up to here, we're probably ok :P
     return Py_BuildValue("i", 1);
 }