Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reshape_image_to_4d_superpixel array seems broken #2020

Closed
prateekiiest opened this issue Mar 7, 2017 · 4 comments
Closed

reshape_image_to_4d_superpixel array seems broken #2020

prateekiiest opened this issue Mar 7, 2017 · 4 comments
Labels
Documentation Affects the documentation

Comments

@prateekiiest
Copy link
Contributor

prateekiiest commented Mar 7, 2017

http://docs.sunpy.org/en/latest/generated/api/sunpy.image.rescale.reshape_image_to_4d_superpixel.html

This should be like this and not like in the docs.

x = np.array([[0, 0, 0, 1, 1, 1], [0, 0, 1, 1, 0, 0], [1, 1, 0, 0, 1, 1], [0, 0, 0, 0, 1, 1], [1, 0, 1, 0, 1, 1], [0, 0, 1, 0, 0, 0]])

Same with
array([[0, 3, 2], [2, 0, 4], [1, 2, 2]])

Not much of an issue, I guess.

@Cadair Cadair added Documentation Affects the documentation [BugFix] labels Mar 7, 2017
@prateekiiest
Copy link
Contributor Author

#2022 PR

@wafels
Copy link
Member

wafels commented Mar 14, 2017

The reason the arrays are formatted the way they are in the docs is to make it easy for the reader to understand what the function is doing. Reformatting as suggested reduces understanding in my opinion.

@prateekiiest
Copy link
Contributor Author

Then should we change it back to normal?

@wafels
Copy link
Member

wafels commented Mar 19, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Affects the documentation
Projects
None yet
Development

No branches or pull requests

3 participants