Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aiaprep with maps besides AIA #2331

Closed
wtbarnes opened this issue Nov 4, 2017 · 2 comments
Closed

Use aiaprep with maps besides AIA #2331

wtbarnes opened this issue Nov 4, 2017 · 2 comments

Comments

@wtbarnes
Copy link
Member

wtbarnes commented Nov 4, 2017

There is a line in sunpy.instr.aia.aiaprep that throws an error if aiaprep() is called on any Map other than an AIA map. However, this function is still useful for centering and derotating other maps, e.g. if one were to overplot AIA emission on an HMI map.

Could this check be removed so that aiaprep can be called on maps besides AIA? It does not seem that anything AIA-specific is being done in this function and that it could be applicable to other maps as well.

@larrymanley
Copy link
Contributor

It is AIA-specific because it adjusts the plate scale (arcsec/pixel) to 0.6. Keep in mind that AIA is 0.6, but HMI is 0.5. Take a look at the code in issue #1697 for an example of compositing AIA and HMI

@wtbarnes
Copy link
Member Author

wtbarnes commented Nov 4, 2017

Ah ok. Forgot about the plate scale values.

The example in that PR should really be added to the gallery example then. I've tried using masked Numpy arrays with composite maps, but for whatever reason the mask is completely ignored once the composite map is created. So if clipping works, then this should be advertised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants