Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aiaprep can not be used to align AIA and HMI images #2747

Closed
Cadair opened this issue Sep 11, 2018 · 3 comments
Closed

aiaprep can not be used to align AIA and HMI images #2747

Cadair opened this issue Sep 11, 2018 · 3 comments
Labels
Bug Probably a bug Effort Low Requires a small time investment map Affects the map submodule Package Novice Requires little knowledge of the internal structure of SunPy Priority High Rapid action required

Comments

@Cadair
Copy link
Member

Cadair commented Sep 11, 2018

aiaprep explicitly checks the type of the map to make sure it's AIAMap when really it should allow HMIMap as well because then you can align AIA images with HMI, and the metadata structure is sufficiently similar that there is no reason why this would not work.

The fix I think would be best would be to allow both AIAMap and HMIMap in this isinstance check. On the other hand you could just drop it altogether and just hope it works 😆

@Cadair Cadair added Bug Probably a bug Package Novice Requires little knowledge of the internal structure of SunPy map Affects the map submodule Priority High Rapid action required Effort Low Requires a small time investment labels Sep 11, 2018
@SolarDrew SolarDrew mentioned this issue Sep 11, 2018
@wtbarnes
Copy link
Member

Duplicate of #2331? Also see discussion in #1697.

@SolarDrew
Copy link
Contributor

Well-spotted. I think having one function rescale both AIA and HMI data is a good solution to both this and #2331 if the plate scale is the only difference, but we'll have to put in a check so that it uses the correct one.

@Cadair
Copy link
Member Author

Cadair commented Sep 12, 2018

if given a HMI map, aiaprep should change it's plate scale to 0.6. As that is how you would align it to the AIA data.

This is defiantly a dupe of #2331 though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Probably a bug Effort Low Requires a small time investment map Affects the map submodule Package Novice Requires little knowledge of the internal structure of SunPy Priority High Rapid action required
Projects
None yet
Development

No branches or pull requests

3 participants