Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hgs_to_hcc(heliogcoord, heliocframe) : Convert from Heliographic Stonyhurst to Heliograpic Carrington. #2470

Closed
gulshan-mittal opened this issue Feb 17, 2018 · 4 comments
Closed

hgs_to_hcc(heliogcoord, heliocframe) : Convert from Heliographic Stonyhurst to Heliograpic Carrington. #2470

gulshan-mittal opened this issue Feb 17, 2018 · 4 comments
Labels
coordinates Affects the coordinates submodule Documentation Affects the documentation

Comments

@gulshan-mittal
Copy link
Contributor

gulshan-mittal commented Feb 17, 2018 •
edited

Wrong Documentation under SunpyCoordinates-> sunpy.coordinates.transformations Module.
It should be Convert from Heliographic Stonyhurst to Heliocentric .
Link to documentation : http://docs.sunpy.org/en/latest/code_ref/coordinates.html#module-sunpy.coordinates.transformations. @Cadair @nabobalis
@nabobalis
Copy link
Contributor

Sorry, I am not sure I see what the problem is.

@gulshan-mittal
Copy link
Contributor Author

@nabobalis
issue1 In this conversion should be Heliographic Stonyhurst to Heliocentric instead of Heliographic Stonyhurst to Heliograpic Carrington.

@nabobalis
Copy link
Contributor

Ah yes. That should be changed.

@ayshih ayshih added coordinates Affects the coordinates submodule Documentation Affects the documentation labels Feb 19, 2018
gulshan-mittal added a commit to gulshan-mittal/sunpy that referenced this issue Mar 4, 2018
@gulshan-mittal
Fix Issue sunpy#2470
8d4537a
nabobalis added a commit that referenced this issue Mar 5, 2018
@nabobalis
Merge pull request #2502 from gulshan-mittal/my-fix1
117ba8f 
Fix Issue #2470 hgs_to_hcc(heliogcoord, heliocframe) : Convert from Heliographic Stonyhurst to Heliograpic Carrington.
@nabobalis
Copy link
Contributor

Fixed by #2502

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
coordinates Affects the coordinates submodule Documentation Affects the documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ayshih @nabobalis @gulshan-mittal