Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to colorbar in map.peek() #4906

Closed
dstansby opened this issue Jan 25, 2021 · 7 comments · Fixed by #4930
Closed

Add label to colorbar in map.peek() #4906

dstansby opened this issue Jan 25, 2021 · 7 comments · Fixed by #4930
Labels
Effort Low Requires a small time investment Feature Request New feature wanted! Good First Issue The best issues for new people to tackle! map Affects the map submodule Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required visualization Affects the visualization submodule

Comments

@dstansby
Copy link
Member

It would be nice to set the colorbar label from the unit of the map data (from the BUNIT FITS keyword), currently it is missing:

Screenshot 2021-01-25 at 14 40 05

@dstansby dstansby added Feature Request New feature wanted! Good First Issue The best issues for new people to tackle! map Affects the map submodule visualization Affects the visualization submodule labels Jan 25, 2021
@tanvimoharir
Copy link

@dstansby I would like to work on this. Please assign this to me. I'm, however ,new to open source ,so any help/guidance is more then welcome. I will start with going through the Developers guide and Newcomers guide for now.
Thanks

@nabobalis nabobalis added Effort Low Requires a small time investment Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required labels Jan 25, 2021
@ayshih
Copy link
Member

ayshih commented Jan 26, 2021

Death to .peek()! Long live .quicklook()! =P

(Of course, .quicklook() doesn't have this feature either...)

@nabobalis
Copy link
Contributor

@dstansby I would like to work on this. Please assign this to me. I'm, however ,new to open source ,so any help/guidance is more then welcome. I will start with going through the Developers guide and Newcomers guide for now.
Thanks

We tend to not use the "assignee" part of GitHub issues, our issues are generally low traffic enough to not cause a problem with not using this feature of GitHub.

The newcomers guide is the best place to start, if you hit any roadblocks, you should join the matrix channel and we debug it there.

@tanvimoharir
Copy link

@nabobalis Thanks! I will do that.

@jeffreypaul15
Copy link
Contributor

How should the label for the colorbar look like, I'm a tad bit confused.

@dstansby
Copy link
Member Author

For the label text, it should just take the unit from the .unit attribute, ie. str(self.unit) - does that clear up the confusion?

@jeffreypaul15
Copy link
Contributor

For the label text, it should just take the unit from the .unit attribute, ie. str(self.unit) - does that clear up the confusion?

Yep, thanks I shall make a PR regarding this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Effort Low Requires a small time investment Feature Request New feature wanted! Good First Issue The best issues for new people to tackle! map Affects the map submodule Package Novice Requires little knowledge of the internal structure of SunPy Priority Low Slow action required visualization Affects the visualization submodule
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants