added colorbar label

[jeffreypaul15]

Description

Fixes #4906
Adds label to colorbar aligning it vertically.
This would change the figure so new hashes will have to be generated if what I've done is right.

[pep8speaks]

Hello @jeffreypaul15! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-01-31 18:00:36 UTC

[nabobalis]

How does it come out?

[jeffreypaul15]

How does it come out?

Should I alter the size?

[nabobalis]

Can we not move the label? Maybe at the top or bottom of the bar?

It looks a bit odd sticking out at the side.

Maybe others disagree.

[jeffreypaul15]

Can we not move the label? Maybe at the top or bottom of the bar?

It looks a bit odd sticking out at the side.

Maybe others disagree.

I suppose moving it to the bottom and increasing the size would make it better?

[dstansby]

I agree it looks odd, if there's an easy way to put it at the top I think that would work well.

[jeffreypaul15]

I agree it looks odd, if there's an easy way to put it at the top I think that would work well.

Does this look better?

[nabobalis]

Maybe the font should be same size as the tick labels?

[jeffreypaul15]

Maybe the font should be same size as the tick labels?

Yeah, I thought so too. I can't seem to find the actual size used though. size=12 seems to best work with it.

[nabobalis]

I feel like it looks better at the bottom.

[jeffreypaul15]

I feel like it looks better at the bottom.

Is this alright?

[nabobalis]

Fine by me, lets see if others agree.

[dstansby]

Yep, I think this looks great, modulo @nabobalis comments above 👍

[nabobalis]

I suspect some figure tests will need updating due to the change as well.

[jeffreypaul15]

I suspect some figure tests will need updating due to the change as well.

Would the tests need updating? I thought only the hashes would have to be changed.

[nabobalis]

I suspect some figure tests will need updating due to the change as well.

Would the tests need updating? I thought only the hashes would have to be changed.

Just the hashes.

[jeffreypaul15]

I suspect some figure tests will need updating due to the change as well.

Would the tests need updating? I thought only the hashes would have to be changed.

Just the hashes.

I'm not too sure on how to generate the hashes as the tox -e figure tests do not pass locally for me. (Similar issue when I was working on draw_quadrangle

[nabobalis]

I suspect some figure tests will need updating due to the change as well.

Would the tests need updating? I thought only the hashes would have to be changed.

Just the hashes.

I'm not too sure on how to generate the hashes as the tox -e figure tests do not pass locally for me. (Similar issue when I was working on draw_quadrangle

The figure tests on circleci tell you the hashes before and after in the logs.

[nabobalis]

Thanks for the PR @jeffreypaul15

[jeffreypaul15]

Thanks for the PR @jeffreypaul15

Always fun contributing to Sunpy! 🚀