Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong date being used for EUI observer coordinate #5450

Closed
dstansby opened this issue Jul 8, 2021 · 2 comments · Fixed by #5462
Closed

Wrong date being used for EUI observer coordinate #5450

dstansby opened this issue Jul 8, 2021 · 2 comments · Fixed by #5462
Labels
Bug Probably a bug Good First Issue The best issues for new people to tackle! Priority High Rapid action required
Milestone

Comments

@dstansby
Copy link
Member

dstansby commented Jul 8, 2021

Currently in sunpy 3.0.x, the date/time of m.observer_coordinate is taken from m.date, which is taken from the DATE-OBS FITS keyword. For Solar Orbiter (and possibly other missions), the coordinate metadata is valid at the time given by DATE-AVG however, which is different to DATE-OBS (see 3.1.1.10 of the Metadata Definition for Solar Orbiter Science Data).

This will be fixed in 3.1 by https://github.com/sunpy/sunpy/pull/5449/files, but we should issue a fix for the 3.0.x branch in the EUI map source.

@dstansby dstansby added Bug Probably a bug Priority High Rapid action required labels Jul 8, 2021
@wtbarnes
Copy link
Member

wtbarnes commented Jul 8, 2021

Should .date on the EUI source just default to 'DATE-AVG'? That seems like the easiest fix here.

@dstansby
Copy link
Member Author

Yep, I think that's the best thing to do.

@dstansby dstansby added the Good First Issue The best issues for new people to tackle! label Jul 12, 2021
@dstansby dstansby added this to the 3.0.2 milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Probably a bug Good First Issue The best issues for new people to tackle! Priority High Rapid action required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants