Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EUI observer coordinate date #5462

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Conversation

dstansby
Copy link
Member

Fixes #5450. Currently I've just passed a custom value to .observer_coordinate property, which means that .observer_coordinate.obstime != .time, to avoid changing the return value of .time.

@dstansby dstansby added this to the 3.0.2 milestone Jul 16, 2021
@dstansby dstansby requested a review from a team as a code owner July 16, 2021 14:03
@dstansby dstansby requested a review from wtbarnes July 16, 2021 14:09
@nabobalis nabobalis removed this from the 3.0.2 milestone Jul 16, 2021
@nabobalis nabobalis added [BugFix] map Affects the map submodule labels Jul 16, 2021
@ayshih
Copy link
Member

ayshih commented Jul 16, 2021

Does this mean that .coordinate_frame.obstime != .coordinate_frame.observer.obstime? (This isn't necessarily a problem, but is better avoided if possible.)

@dstansby
Copy link
Member Author

Does this mean that .coordinate_frame.obstime != .coordinate_frame.observer.obstime? (This isn't necessarily a problem, but is better avoided if possible.)

Yes, it does, because .coordinate_frame draws a date from .wcs, which in turn draws from .date.

The other way to go with this is to override .date to return DATE-AVG instead of DATE-OBS, which might be better for overall consistency? (and was suggested by @wtbarnes here: #5450 (comment))

@wtbarnes
Copy link
Member

wtbarnes commented Jul 16, 2021

I'm more inclined to override .date. However, I'm not really bothered either way as this mostly matters for bugfix releases on 3.0.x as #5449 will solve this problem by returning DATE-AVG from .date anyway.

@dstansby dstansby added this to the 3.0.2 milestone Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
map Affects the map submodule
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong date being used for EUI observer coordinate
4 participants