-
-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for np.datetime64 and strings with timezone info #1344
Conversation
@dpshelio Finally added support for np.datetime64 input which I guess the issue was about in the first place. Also added support for input strings with timezone information. Added (some important to this issue) Test Cases that are supported. Also solved the problem of possible multiple '-' in time_string |
@ankitkmr why did you closed the other PR? You could have just updated it... Well, my comments from #1343 still apply here, e.g., there is repetition in the code that should be reduced. |
@dpshelio Umm sorry I couldn't figure out back then that I could simply commit and update that PR in itself. It wont happen in future. As for the repetition, corrected. |
This offers a solution to the issue sunpy#798
@dpshelio OK I condensed it even more I agree too much useless code there !! Oops..I added the tests as well according to the dev guide. They can be found in PR1345 (new PR) this I guess happened because I was committing to a new file. |
No, they are not in a different pul request because you've made changes in different files, but because you made the changes in a different branch. If you do it in the same branch you would see it here. So, probably you could do (I've not tested it): $ git checkout ankitkmr-patch-3
$ git cherry-pick 1821096
$ git push |
@dpshelio Done !! Now I think I am moving on to writing my proposal !! |
As written, the code requires timedelta to be imported explicitly in order for this PR to pass. |
Thanks @wafels just noticed that and added its import to the test_time.py file |
This offers a solution to the issue #798