[unidown] Preliminary version of Unified Downloader Docs. More improvements to come. #1623
Conversation
can be read into GOESLightCurve object.
be obtained if dat is at latter edge of a GOES satellite operational time range.
trying to improve the docstring of the reshape function
Added function to shift a map
This catches the edge case of the old style WCS headers being passed to WCS where it is `solar_x` rather than `solar-x` like it is for MDI etc.
Added documentation on how backport a contribution
More solar-x solar-y fixes.
update figure hashes, again
…uteError: Unknown property controls'
Animation titles
|
hey @Cadair , The second commit are the edits I made. The only problem is sphinx is unable to build documentation for different downloader clients eveclient,rhessiclient etc.Check the init.py file in /dataretriever/sources folder. Compile the docs to see the results. |
sudk1896
changed the title
|
hey @sudk1896 there are a few syntax errors in some docstrings for instance here: https://travis-ci.org/sunpy/sunpy/jobs/98340395#L1589 |
|
@Cadair Its a problem with the indentation in /sunpy/net/dataretriever/downloader_factory.py. I fixed that on my local machine and passes without any warnings/errors. |
|
@sudk1896 can you push the fix? |
|
@Cadair : Yeah, That would be no problem. Pushed the changes. Like I said before, Its still incomplete, there is still no docs for the indiviual clients. Some problem with Sphinx , I believe. You can manually change them in the corresponding /home/sudarshan/sunpy/doc/source/api/ .rst files, but that wouldn't be the way to go about. Hey @Cadair something happened last commit is the only one to be pushed. Apologies. |
|
@sudk1896 not really sure about these two warnings: https://travis-ci.org/sunpy/sunpy/jobs/100327101#L1573 |
|
no idea what is causing them... |
|
@Cadair: Will look into it. |
|
Edit: Nevermind, it's to unidown. |
Cadair
changed the title
|
@Cadair: I could create a new PR with only the requisite commits if you want. |
|
@sudk1896 no it was my mistake, I didn't realise you were bringing in commits from master as well, which is ok. Have you tried to debug the documentation warnings? |
|
@Cadair: Busy implementing another client in unidown. But I will have a look at this the weekend for sure. |
|
Thanks @sudk1896 I fixed this up and merged it in manually. |
Fixed the test_vso function which was failing due to an AttributeError.
Link:- http://pastebin.com/DDsntvT3