[unidown] SWAPClient implementation with tests. Review at later date. #1680
Conversation
sudk1896
changed the title
|
@sudk1896 Can you add some tests of using the SWAPClient through the Fido interface? |
|
@Cadair: Sure. Would do it in the next couple of days. |
| str19 str19 str6 str4 | ||
| ------------------- ------------------- ------ ---------- | ||
| 2015-12-28 00:00:00 2015-12-29 00:00:00 Proba2 swap | ||
| 2015-12-29 00:00:00 2015-12-30 00:00:00 Proba2 swap] |
There was a problem hiding this comment.
This output is showing the wrong dates.
| '%Y/%m/%d/' | ||
| '{instrument}_lv1_%Y%m%d_%H%M%S.fits') | ||
| crawler = Scraper(url_pattern, instrument= 'swap') | ||
| if not timerange: |
There was a problem hiding this comment.
What is the reasoning behind this? If timerange is not specified correctly this should error??
There was a problem hiding this comment.
The earliest data available on the http://proba2.oma.be/swap/data/bsd/ is from SWAP_STARTDATE, so if the user specifies a date earlier than this, it would rightfully err.
There was a problem hiding this comment.
yeah, that's not what I mean, you are catching a case here where timerange is None or False, which is not valid input so should just error not be caught.
There was a problem hiding this comment.
Yes, It should throw an error. What error should I output ValueError, AttributeError etc ? I am thinking a simple exception saying input a valid timerange maybe.
There was a problem hiding this comment.
I am not sure it needs to be explicitly caught, Python will throw a ValueError (?) when you do the comparison to SWAP_STARTDATE.
There was a problem hiding this comment.
it's generally good form to not catch things unless you need to.
There was a problem hiding this comment.
Well, I have been testing it. If you don't pass time at all,
raise TypeError('{0!r}'.format(types))
If you pass an empty string in Time,
TypeError: __init__() takes at least 2 arguments (1 given)
If you pass timeranges in wrong order(start date greater than end date) it doesn't return an error or any result at all. So, I doubt why we should do the error checking there ?
|
Redid this as part of my Summer of Code. Closing this. |
My SWAPClient implementation got lost when I updated my swap branch to incorporate the latest changes from unidown. Its the same thing as my previous PR.
Review the changes at a later date.
@Cadair @dpshelio