Data directory should not be created on import

[nitinkgp23]

Fixes #2018

Before:

Upon doing import sunpy, a directory was created on /home/sunpy/data , irrespective of whether we download data or not.

After:

Upon doing import sunpy, the path is saved in the config file but the directory is not created. The directory is first created when we try downloading any data.

[pep8speaks]

Hello @nitinkgp23! Thanks for updating the PR.

• In the file sunpy/database/tests/test_database.py, following are the PEP8 issues :

Line 504:1: E302 expected 2 blank lines, found 1
Line 511:1: E302 expected 2 blank lines, found 1
Line 820:101: E501 line too long (110 > 100 characters)
Line 821:101: E501 line too long (109 > 100 characters)
Line 852:68: E251 unexpected spaces around keyword / parameter equals
Line 852:70: E251 unexpected spaces around keyword / parameter equals
Line 853:67: E251 unexpected spaces around keyword / parameter equals
Line 853:69: E251 unexpected spaces around keyword / parameter equals

• In the file sunpy/instr/goes.py, following are the PEP8 issues :

Line 977:5: E122 continuation line missing indentation or outdented

• In the file sunpy/lightcurve/lightcurve.py, following are the PEP8 issues :

Line 126:16: E251 unexpected spaces around keyword / parameter equals
Line 126:18: E251 unexpected spaces around keyword / parameter equals

• In the file sunpy/map/map_factory.py, following are the PEP8 issues :

Line 173:17: E129 visually indented line with same indent as next logical line

• In the file sunpy/net/tests/test_download.py, following are the PEP8 issues :

Line 4:1: E265 block comment should start with '# '
Line 42:27: E261 at least two spaces before inline comment
Line 42:28: E262 inline comment should start with '# '
Line 44:5: E306 expected 1 blank line before a nested definition, found 0
Line 65:1: E302 expected 2 blank lines, found 1
Line 79:1: E302 expected 2 blank lines, found 1
Line 96:5: E731 do not assign a lambda expression, use a def
Line 103:101: E501 line too long (103 > 100 characters)
Line 104:101: E501 line too long (101 > 100 characters)
Line 117:1: E302 expected 2 blank lines, found 1
Line 126:9: E731 do not assign a lambda expression, use a def
Line 148:1: E302 expected 2 blank lines, found 1
Line 153:5: E731 do not assign a lambda expression, use a def

• In the file sunpy/util/create.py, following are the PEP8 issues :

Line 100:33: E122 continuation line missing indentation or outdented

Comment last updated on March 21, 2017 at 16:04 Hours UTC

[nitinkgp23]

Hey @Cadair, Can you please review the PR?

[Cadair]

Thanks for the PR!

It's not only the sample data that uses the sunpy/data directory. It is the default location for the VSO and other clients in sunpy.net. I think a helper in the config module for "get or create download dir" and a through search through the code for instances of the download dir.

[nitinkgp23]

Yeah, I thought so. But, I checked it by directly downloading a file using jsoc client, after deleting the download directory at $HOME and the directory got automatically created and download was successful.

[Cadair]

It seems that some of the travis errors here are due to the directory not existing: https://travis-ci.org/sunpy/sunpy/jobs/208183122#L2488

Seems that it's in lightcurve?

[nitinkgp23]

Ahh :( . So what's the best way out? Make a through search, and add the command of creating directory everywhere? Or, is there any shortcut, that I am missing?

[Cadair]

I would make a function in config which gets the config value of the download dir, and makes the dir if it does not exist. Then search through the code and replace the download dir get call with that function.

[nitinkgp23]

Okkay, I will make the changes :). Thanks.

[Cadair]

There is no need for two function calls here (get default directory and create it) this can be done in one call.

Also, this is still to early to create the directory. We only want to be creating it upon use, so if the functions are called with the default data dir we should make the directory then, rather than on import of this submodule.

To give you an example for this file you want to replace every occurrence of DATA_PATH with sunpy.config.get_and_create_download_dir().

[Cadair]

This is the same for the other files as well.

[nitinkgp23]

@Cadair I will modify other files too, if this is okay.

[nitinkgp23]

Is this what we want?

[Cadair]

looks good!

[Cadair]

This can use the function.

[Cadair]

also @nitinkgp23 if you merge master in or rebase the build should pass.

[Cadair]

@nabobalis Your first backport.

[Cadair]

@kbj Will this fix your concerns?