Update time.py Removed extract_time

[prateekiiest]

@dpshelio , added a deprecated decorator.
The function should now issue a warning if invoked.

issue #2024

[pep8speaks]

Hello @prateekiiest! Thanks for updating the PR.

• In the file sunpy/time/tests/test_time.py, following are the PEP8 issues :

Line 206:1: E303 too many blank lines (3)

• In the file sunpy/time/time.py, following are the PEP8 issues :

Line 124:1: E303 too many blank lines (4)

Comment last updated on March 09, 2017 at 14:44 Hours UTC

[prateekiiest]

Or is it required to totally remove the extract_time function??

ping @Cadair @dpshelio

[prateekiiest]

I removed the function instead of using deprecated

[m-charlton]

Cheers

[Cadair]

The test is going to need to be removed and it's going to need a changelog.

[prateekiiest]

So all the tests including
test_extract_time_illegal_args():
test_extract_time_best_effort()
must be removed , since they use extract_time().

Am I right?

[Cadair]

yes, anything that calls extract time will need removing.

[prateekiiest]

Done @Cadair

[prateekiiest]

Done removing the tests that call extract_time.

[Cadair]

Needs a change log due to the API change :)

[prateekiiest]

OK, on the way.

[prateekiiest]

@Cadair
Is it ok, now?

[Cadair]

The tests have failed. I am going to guess you haven't removed extract_time from the __all__ list somewhere. Check the build logs and run the tests locally before you push.

[prateekiiest]

Removed extract_time from all

[prateekiiest]

Removed extract_time from import